-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node-core): Expand @opentelemetry/instrumentation
range to cover 0.203.0
#17043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^0.202.0
doesn't allow 0.203.0
?
Actually it does... will close this 😅. edit: actually it doesn't. So this is a mess, |
016ab81
to
ee888c2
Compare
packages/node-core/package.json
Outdated
@@ -60,7 +60,7 @@ | |||
"@opentelemetry/api": "^1.9.0", | |||
"@opentelemetry/context-async-hooks": "^1.30.1 || ^2.0.0", | |||
"@opentelemetry/core": "^1.30.1 || ^2.0.0", | |||
"@opentelemetry/instrumentation": "^0.57.1 || ^0.202.0", | |||
"@opentelemetry/instrumentation": "^0.57.1 || >=0.200.0 <1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, can this just be >= 0.57.1 <1
? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: OpenTelemetry Dependency Removal Error
The @opentelemetry/instrumentation
dependency was accidentally removed from both peerDependencies
and devDependencies
in packages/opentelemetry/package.json
. This is inconsistent with the PR's goal of expanding OpenTelemetry version support (e.g., to include 0.203.0
or ">=0.57.1 <1"
as seen in other packages), and will break OpenTelemetry integration.
packages/opentelemetry/package.json#L46-L54
sentry-javascript/packages/opentelemetry/package.json
Lines 46 to 54 in e6df021
"@opentelemetry/context-async-hooks": "^1.30.1 || ^2.0.0", | |
"@opentelemetry/core": "^1.30.1 || ^2.0.0", | |
"@opentelemetry/sdk-trace-base": "^1.30.1 || ^2.0.0", | |
"@opentelemetry/semantic-conventions": "^1.34.0" | |
}, | |
"devDependencies": { | |
"@opentelemetry/api": "^1.9.0", | |
"@opentelemetry/context-async-hooks": "^1.30.1", | |
"@opentelemetry/core": "^1.30.1", |
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.