Skip to content

feat(node-core): Expand @opentelemetry/instrumentation range to cover 0.203.0 #17043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025

Conversation

andreiborza
Copy link
Member

No description provided.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^0.202.0 doesn't allow 0.203.0?

@andreiborza
Copy link
Member Author

andreiborza commented Jul 16, 2025

Actually it does... will close this 😅.

edit: actually it doesn't.

So this is a mess, ^ only covers patches for 0.x. I think we can go ahead and cover only ^0.203.0.

@andreiborza andreiborza reopened this Jul 16, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@andreiborza andreiborza force-pushed the ab/bump-otel-instrumentation-range branch from 016ab81 to ee888c2 Compare July 16, 2025 17:07
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@@ -60,7 +60,7 @@
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/context-async-hooks": "^1.30.1 || ^2.0.0",
"@opentelemetry/core": "^1.30.1 || ^2.0.0",
"@opentelemetry/instrumentation": "^0.57.1 || ^0.202.0",
"@opentelemetry/instrumentation": "^0.57.1 || >=0.200.0 <1",
Copy link
Member

@mydea mydea Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can this just be >= 0.57.1 <1? 😅

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: OpenTelemetry Dependency Removal Error

The @opentelemetry/instrumentation dependency was accidentally removed from both peerDependencies and devDependencies in packages/opentelemetry/package.json. This is inconsistent with the PR's goal of expanding OpenTelemetry version support (e.g., to include 0.203.0 or ">=0.57.1 <1" as seen in other packages), and will break OpenTelemetry integration.

packages/opentelemetry/package.json#L46-L54

"@opentelemetry/context-async-hooks": "^1.30.1 || ^2.0.0",
"@opentelemetry/core": "^1.30.1 || ^2.0.0",
"@opentelemetry/sdk-trace-base": "^1.30.1 || ^2.0.0",
"@opentelemetry/semantic-conventions": "^1.34.0"
},
"devDependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/context-async-hooks": "^1.30.1",
"@opentelemetry/core": "^1.30.1",

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@andreiborza andreiborza merged commit 5319942 into develop Jul 17, 2025
169 of 170 checks passed
@andreiborza andreiborza deleted the ab/bump-otel-instrumentation-range branch July 17, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants